Ticket #1484577 (closed Patches: fixed)

Opened 14 months ago

Last modified 10 months ago

Received header not used when Date header is missing

Reported by: memoryhole Owned by: thomasb
Priority: 5 Milestone: 0.1-stable
Component: Client Scripts Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

Some email systems (such as the NYTimes.com email-article-to-a-friend service, and iTunes weekly mailings) do not have Date headers (an RFC nonconformity which is not corrected by qmail servers). Most mail reader programs compensate for emails that don't have Date headers by using the timestamp on the first Received header when the Date header is missing. Roundcube doesn't, and so emails without Date headers are sorted with a null date, so the show up in unexpected places in the lists of emails sorted by date.

Attachments

bad_date_display.patch (1.5 kB) - added by memoryhole 14 months ago.
A fix for the display problem. Extracts the date field from the first-added Received header.

Change History

Changed 14 months ago by memoryhole

A fix for the display problem. Extracts the date field from the first-added Received header.

  Changed 14 months ago by thomasb

  • owner set to thomasb
  • status changed from new to assigned
  • type changed from Bugs to Patches
  • milestone set to 0.1-stable

We have to check carefully if INTERNALDATE always works for sorting.

follow-up: ↓ 3   Changed 14 months ago by thomasb

Also fetching the Received header causes a much higher data load. And this only to display non-conform mails. I don't know if this is worth it...

in reply to: ↑ 2   Changed 14 months ago by memoryhole

Replying to thomasb:

Also fetching the Received header causes a much higher data load. And this only to display non-conform mails. I don't know if this is worth it...

Perhaps it would be better to only fetch the Received headers for messages without Date headers?

  Changed 10 months ago by till

  • owner changed from thomasb to till
  • status changed from assigned to new

Committed bad_date_display.patch in r1049.

I will split the 2nd patch into a feature request and delay it.

  Changed 10 months ago by till

  • status changed from new to closed
  • resolution set to fixed

Closing this, feature request in #1484769 (delayed to 0.1.1).

@memoryhole: Thanks for the patch, please reopen if this doesn't work!

  Changed 10 months ago by till

  • status changed from closed to reopened
  • resolution deleted

Re-opened to revise the patch. ;-)

  Changed 10 months ago by till

Revision r1053 is my attempt to make it better, but it's not working yet - not sure why.

  Changed 10 months ago by till

  • owner changed from till to thomasb
  • status changed from reopened to new

Fixed by thomasb in r1054! Thanks!

  Changed 10 months ago by till

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.