Ticket #1484623 (closed Patches: fixed)

Opened 10 months ago

Last modified 2 months ago

patch: adds support for the flagged/unflagged message column as config option

Reported by: seansan Owned by:
Priority: 5 Milestone: 0.2-beta
Component: Core functionality Version: 0.1-rc1
Severity: normal Keywords:
Cc:

Description

Hi there,

I have added the functionality to show the flagged/unflagged column for mail messages in the message listing - configurable in config/default set to FALSE. Attached you will find two new icons + the full patch against SVN 388. Also an example view. Tested ok.

I think is a welcome addition to RC and at least offers the functionality to show flagged messages (if desired by the admin via config).

TODO: (not now) functionality to set the message flag to flagged/unflagged from roundcube by event.

Attachments

patch_add_flagged_column_svn388.zip (2.5 kB) - added by seansan 10 months ago.
patch and icons to add functionality
example.JPG (4.2 kB) - added by seansan 10 months ago.
Example of new functionality
patch_add_flagged_column_and_event_svn388.zip (4.0 kB) - added by seansan 10 months ago.
Version 2 - with backend event triggering and backend integration
patch_add_flagged_column_and_event_svn388.2.zip (4.0 kB) - added by seansan 10 months ago.
VERSION 3 - patch file 22 okt - fixed UNFLAGGING
patch_add_flagged_column_and_event_svn388_v4.zip (4.3 kB) - added by seansan 10 months ago.
VERSION 4 - patch file 8 nov - fixed column header renamin
patch_add_flagged_column_and_event_svn_r1142_v5.zip (10.9 kB) - added by RaphaelKa 6 months ago.
VERSION 5 - patched against current trunk - two fixes
patch_add_flagged_column_and_event_svn_r1170_v6.zip (4.8 kB) - added by RaphaelKa 6 months ago.
VERSION 6 - unflagging was broken for me, bugfixed and with other icon
patch_add_flagged_column_and_event_svn_r1256_v7.zip (4.9 kB) - added by RaphaelKa 5 months ago.
patched against revision 1256 (~ 0.1.1-stable) - minor fixes because of merge conflict

Change History

Changed 10 months ago by seansan

patch and icons to add functionality

Changed 10 months ago by seansan

Example of new functionality

follow-up: ↓ 2   Changed 10 months ago by thomasb

  • milestone changed from 0.1-rc2 to 0.1.1

Later.

Changed 10 months ago by seansan

Version 2 - with backend event triggering and backend integration

in reply to: ↑ 1   Changed 10 months ago by seansan

Replying to thomasb:

Later.

OK. See updated patch with event trigger onclick to toggle icon and flag, also updates the IMAP backend

  Changed 10 months ago by seansan

See attachment DIFF : Version 2 - with backend event triggering and backend integration.

Updated patch with event trigger onclick to toggle icon and flag, also updates the IMAP backend

Changed 10 months ago by seansan

VERSION 3 - patch file 22 okt - fixed UNFLAGGING

Changed 10 months ago by seansan

VERSION 4 - patch file 8 nov - fixed column header renamin

Changed 6 months ago by RaphaelKa

VERSION 5 - patched against current trunk - two fixes

  Changed 6 months ago by seansan

See dupe #1484802 (also with patch)

Changed 6 months ago by RaphaelKa

VERSION 6 - unflagging was broken for me, bugfixed and with other icon

  Changed 6 months ago by RaphaelKa

appendix: also added some improvements (e.g. entries for marking toolbar menu) from #1484802

  Changed 5 months ago by till

  • milestone changed from 0.1.1 to 0.2-beta

Changed 5 months ago by RaphaelKa

patched against revision 1256 (~ 0.1.1-stable) - minor fixes because of merge conflict

  Changed 2 months ago by alec

  • status changed from new to closed
  • resolution set to fixed

Patch with few modifications added in r1580.

  Changed 2 months ago by the_glu

You simply rox dude °o°

Note: See TracTickets for help on using tickets.