Ticket #1484730 (closed Patches: fixed)

Opened 10 months ago

Last modified 3 months ago

Better native languages support, including russian and others

Reported by: Javer Owned by: thomasb
Priority: 2 Milestone: 0.2-beta
Component: PHP backend Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

This patch give you easy way to provide localization of Roundcube for using in local environment. For example, in the Ukraine, in Russia and in other countries are widely used messages with headers encoded in Windows-1251 or KOI8-R. In this case after applying patch you should only specify in main.inc.php something like this:

$rcmail_config['locale_charset'] = 'CP1251';

By default ISO-8859-1 encoding are used, therefore for a non-cyrillic users there is no any visible changes. And developers of Roundcube can safely permanent apply this patch to the distributive. Patch is for revision 955 of svn-trunk. File KOI8R.map should be placed in folder program/lib/encoding/ for KOI8-R support.

Attachments

roundcube-r955-charset.diff (7.3 kB) - added by Javer 10 months ago.
Patch for better native languages support, for example russian and others
KOI8R.map (11.2 kB) - added by Javer 10 months ago.
Should be placed in folder program/lib/encoding/ for KOI8-R support
roundcube-charset-new.diff (5.6 kB) - added by Javer 10 months ago.
Fixed version of the patch

Change History

Changed 10 months ago by Javer

Patch for better native languages support, for example russian and others

Changed 10 months ago by Javer

Should be placed in folder program/lib/encoding/ for KOI8-R support

Changed 10 months ago by thomasb

  • component changed from Client to PHP backend
  • severity changed from major to normal

Patch needs to be cleaned up:

1) rcube_imap gets a property 'charset' but this is not always used. Replace all $GLOBALS['CONFIG']['locale_charset'] with $this->charset

2 ) Don't use $GLOBALS['CONFIG'] in classes that are located in program/lib/ because these are external libs and should not be altered.

Changed 10 months ago by Javer

Fixed version of the patch

Changed 10 months ago by Javer

Here is a fixed version of the patch

Changed 10 months ago by thomasb

  • owner set to thomasb
  • status changed from new to assigned
  • milestone set to 0.1.5

Changed 6 months ago by anonymous

  • milestone deleted

Milestone 0.1.5 deleted

Changed 3 months ago by thomasb

  • status changed from assigned to closed
  • resolution set to fixed

This actually fixed with the new 'default_charset' config option. Added KOI8-R map in r1677

Changed 3 months ago by alec

  • milestone set to 0.2-beta
Note: See TracTickets for help on using tickets.