Ticket #1485297 (closed Bugs: fixed)

Opened 3 months ago

Last modified 3 months ago

Signature does not show when HTML composing is on by default

Reported by: rosali Owned by:
Priority: 5 Milestone: 0.2-beta
Component: User Interface Version: 0.2-alpha
Severity: normal Keywords:
Cc:

Description

...

to fix it add in editor.js to tiny init:

oninit : "change_identity",

and add javascript code ...

function change_identity(){

rcmail.change_identity(document.getElementById("rcmcomposefrom"));

}

_

A further problem in IE 7 occurs if you are replying a message which contains a RoundCube signature (<span id="_rc_sig">...</span>). IE throws an error when trying to change the identity.

To fix this a have edited app.js ... case send (around line 888):

case 'send':

if (!this.gui_objects.messageform)

break;

if (!this.check_compose_input())

break;

// Reset the auto-save timer self.clearTimeout(this.save_timer);

// Find me: ... // Remove signature id "_rc_sig" --- Start tinyMCE.triggerSave();

var body = document.getElementById("compose-body").value;

if(body)

{

body = body.replace(/_rc_sig/g,"");

document.getElementById("compose-body").value = body;

}

tinyMCE.get("compose-body").setContent(body);

// Remove signature id "_rc_sig" --- End

Change History

follow-up: ↓ 2   Changed 3 months ago by alec

  • milestone changed from later to 0.2-beta

in reply to: ↑ 1   Changed 3 months ago by rosali

oops ... if you adapt my code, please do not miss to check tinyMCE object. Otherwise there are JS error when sending plain text messages!

  Changed 3 months ago by rosali

Since you have embedded signature into a div instead of span tags, no javascript error is thrown anymore. Nethertheless I suggest to remove the signature id on sending the message. Otherwise there is no signature added on replied or forwarded messages if they already contain any RoundCube signature.

  Changed 3 months ago by alec

  • status changed from new to closed
  • resolution set to fixed

Fixed in r1700.

Note: See TracTickets for help on using tickets.